Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LocalWaker memory leak and some stability attributes #122244

Merged
merged 1 commit into from
Mar 10, 2024
Merged

fix: LocalWaker memory leak and some stability attributes #122244

merged 1 commit into from
Mar 10, 2024

Conversation

tvallotton
Copy link
Contributor

@tvallotton tvallotton commented Mar 9, 2024 •
edited by Noratrieb
Loading

fixes #122180.

@tvallotton
fix: remove memory leak due to missing drop implementation for local …
092a1ab 
…waker. Also, fix some

of the stability attributes of LocalWaker's methods.
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 9, 2024
@Noratrieb Noratrieb changed the title fix: memory leak and some stability attributes fix: LocalWaker memory leak and some stability attributes Mar 9, 2024
@Noratrieb
Copy link
Member

Changed the PR title to mention LocalWaker and changed the PR description to "fixes", which will cause GitHub to automatically close the issue.
@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2024

📌 Commit 092a1ab has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#122244 - tvallotton:local_waker_leak_fix, r…
8d232c9 
…=Nilstrieb

fix: LocalWaker memory leak and some stability attributes

fixes rust-lang#122180.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122260 - matthiaskrgr:rollup-ik8lga9, r=matth…
88de7b1 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#121561 (Detect typos for compiletest test directives)
 - rust-lang#121567 (Avoid some interning in bootstrap)
 - rust-lang#121685 (Fixing shellcheck comments on lvi test script)
 - rust-lang#121833 (Suggest correct path in include_bytes!)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#121907 (skip sanity check for non-host targets in `check` builds)
 - rust-lang#122029 (When displaying multispans, ignore empty lines adjacent to `...`)
 - rust-lang#122221 (match lowering: define a convenient struct)
 - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes)
 - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122244 - tvallotton:local_waker_leak_fix, r…
55674a8 
…=Nilstrieb

fix: LocalWaker memory leak and some stability attributes

fixes rust-lang#122180.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Closed
@RalfJung
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122273 - matthiaskrgr:rollup-cjnrh8i, r=matth…
e7cfe98 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#112136 (Add std::ffi::c_str module)
 - rust-lang#113525 (Dynamically size sigaltstk in std)
 - rust-lang#121685 (Fixing shellcheck comments on lvi test script)
 - rust-lang#121833 (Suggest correct path in include_bytes!)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds)
 - rust-lang#122221 (match lowering: define a convenient struct)
 - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes)
 - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error)
 - rust-lang#122264 (add myself to rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122244 - tvallotton:local_waker_leak_fix, r…
2241ba9 
…=Nilstrieb

fix: LocalWaker memory leak and some stability attributes

fixes rust-lang#122180.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 10, 2024
@jhpratt
Rollup merge of rust-lang#122244 - tvallotton:local_waker_leak_fix, r…
bb3f082 
…=Nilstrieb

fix: LocalWaker memory leak and some stability attributes

fixes rust-lang#122180.
@jhpratt jhpratt mentioned this pull request Mar 10, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122283 - matthiaskrgr:rollup-w3sau3u, r=matth…
cdb775c 
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#112136 (Add std::ffi::c_str module)
 - rust-lang#113525 (Dynamically size sigaltstk in std)
 - rust-lang#121567 (Avoid some interning in bootstrap)
 - rust-lang#121642 (Update a test to support Symbol Mangling V0)
 - rust-lang#121685 (Fixing shellcheck comments on lvi test script)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#121942 (std::rand: enable getrandom for dragonflybsd too.)
 - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds)
 - rust-lang#122221 (match lowering: define a convenient struct)
 - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes)
 - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error)
 - rust-lang#122264 (add myself to rotation)
 - rust-lang#122269 (doc/rustc: Move loongarch64-unknown-linux-musl to Tier 3)
 - rust-lang#122271 (Fix legacy numeric constant diag items)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4faf535 into rust-lang:master Mar 10, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@rust-timer
Unrolled build for rust-lang#122244
6ce56ff 
Rollup merge of rust-lang#122244 - tvallotton:local_waker_leak_fix, r=Nilstrieb

fix: LocalWaker memory leak and some stability attributes

fixes rust-lang#122180.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

Memory leak in LocalWaker
6 participants
@tvallotton @rustbot @Noratrieb @bors @RalfJung @cuviper